<html>
<head><meta charset="utf-8"><title>rustc-dev-guide submodule · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-dev-guide.20submodule.html">rustc-dev-guide submodule</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="225366281"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-dev-guide%20submodule/near/225366281" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-dev-guide.20submodule.html#225366281">(Feb 05 2021 at 22:24)</a>:</h4>
<p>It appears that <code>rust-lang/rust</code> has the rustc-dev-guide as a submodule at <code>src/doc/rustc-dev-guide</code>. However, the submodule hasn't been updated since April 2020. Should we remove the submodule or update it?</p>



<a name="225399004"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-dev-guide%20submodule/near/225399004" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-dev-guide.20submodule.html#225399004">(Feb 06 2021 at 08:40)</a>:</h4>
<p>I didn’t even know it was available in the doc folder</p>



<a name="225412109"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-dev-guide%20submodule/near/225412109" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Julian-Wollersberger <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-dev-guide.20submodule.html#225412109">(Feb 06 2021 at 13:33)</a>:</h4>
<p>AFAIK that this was the directory where the dev guide once lived. It was moved into a separate repo some time ago and kept as a submodule.</p>



<a name="225412287"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-dev-guide%20submodule/near/225412287" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Julian-Wollersberger <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-dev-guide.20submodule.html#225412287">(Feb 06 2021 at 13:37)</a>:</h4>
<p>I'm in favor of removing it, and leaving a <code>src/doc/readme.md</code> with a link to the dev guide repo.<br>
Submodules can be a pain to deal with anyway, and apparently nobody needed the dev guide _inside_ the main repo for so long.</p>



<a name="225439516"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-dev-guide%20submodule/near/225439516" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-dev-guide.20submodule.html#225439516">(Feb 07 2021 at 01:31)</a>:</h4>
<p>working on a PR</p>



<a name="225439874"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-dev-guide%20submodule/near/225439874" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-dev-guide.20submodule.html#225439874">(Feb 07 2021 at 01:42)</a>:</h4>
<p>PR to remove submodule: <a href="https://github.com/rust-lang/rust/issues/81848">#81848</a></p>



<a name="241642038"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-dev-guide%20submodule/near/241642038" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-dev-guide.20submodule.html#241642038">(Jun 05 2021 at 15:34)</a>:</h4>
<p>That PR has been closed, seems we decided to update the submodule for now. It's unclear to me that we just want to include it in rust-docs, i.e. we don't check the toolstate, or we also want to check it. So, do y'all still want to leave the instructions on README ( <a href="https://github.com/rust-lang/rustc-dev-guide#how-to-fix-toolstate-failures">https://github.com/rust-lang/rustc-dev-guide#how-to-fix-toolstate-failures</a> )?</p>



<a name="241642666"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-dev-guide%20submodule/near/241642666" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-dev-guide.20submodule.html#241642666">(Jun 05 2021 at 15:48)</a>:</h4>
<p>I think we should implement <a href="https://github.com/rust-lang/rust/pull/81848#issuecomment-787588985">https://github.com/rust-lang/rust/pull/81848#issuecomment-787588985</a> and then remove the submodule and delete the instructions.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>